Skip to content

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jan 12, 2020

This is blocked because rustc_lint::context is not pub module and CheckLintNameResult is not marked as pub use.

changelog: none

@JohnTitor
Copy link
Member Author

Upstream change is here: rust-lang/rust#68145

@JohnTitor JohnTitor added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Jan 12, 2020
@phansch
Copy link
Contributor

phansch commented Jan 13, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 13, 2020

📌 Commit 17e5517 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 13, 2020

⌛ Testing commit 17e5517 with merge 9c24afc...

bors added a commit that referenced this pull request Jan 13, 2020
Rustup to rust-lang/rust#68045

This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`.

changelog: none
@bors
Copy link
Contributor

bors commented Jan 13, 2020

💔 Test failed - status-appveyor

@JohnTitor
Copy link
Member Author

Let me take a look (and I've realized to forget formatting).

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Jan 13, 2020
@JohnTitor
Copy link
Member Author

Okay, I think it should be ready to go.

@phansch
Copy link
Contributor

phansch commented Jan 13, 2020

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Jan 13, 2020

📌 Commit ce1c6b2 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 13, 2020

⌛ Testing commit ce1c6b2 with merge 920cdb5...

bors added a commit that referenced this pull request Jan 13, 2020
Rustup to rust-lang/rust#68045

This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`.

changelog: none
@bors
Copy link
Contributor

bors commented Jan 13, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 920cdb5 to master...

@bors bors merged commit ce1c6b2 into rust-lang:master Jan 13, 2020
@JohnTitor JohnTitor deleted the rustup-0112 branch January 13, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants